Skip to content

Change some truncrank args to kwargs #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mtfishman merged 1 commit into from
Apr 24, 2025
Merged

Change some truncrank args to kwargs #22

mtfishman merged 1 commit into from
Apr 24, 2025

Conversation

@mtfishman
Copy link
Collaborator

@mtfishman mtfishman commented Apr 24, 2025

Split off from #19.

@mtfishman mtfishman requested a review from lkdvos April 24, 2025 15:20
@mtfishman mtfishman mentioned this pull request Apr 24, 2025
Merged
@mtfishman
Copy link
Collaborator Author

mtfishman commented Apr 24, 2025 •
edited
Loading

The motivation is to make the interface closer to sort, and also because I think it would be easy to forget which argument is which if they are kept as positional arguments. (I.e. I think truncrank(10; by=abs, rev=false) is more self-explanatory than truncrank(10, abs, false)).

@codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/implementations/truncation.jl 87.32% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman merged commit 2364e25 into QuantumKitHub:main Apr 24, 2025
9 checks passed
@mtfishman mtfishman deleted the truncrank_kwargs branch April 24, 2025 16:14
Jutho pushed a commit that referenced this pull request May 11, 2025
@mtfishman @Jutho
Change some truncrank args to kwargs (#22)
f28e2d3
mtfishman referenced this pull request May 22, 2025
@mtfishman @Jutho @lkdvos
Support unsorted spectra in TruncationKeepAbove/Below (#26)
1e86aea 
Co-authored-by: Jutho <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jutho Jutho Jutho approved these changes

@lkdvos lkdvos lkdvos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtfishman @Jutho @lkdvos